Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recursive-include to grab spec.yaml and favicons #347

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

jasongrout
Copy link
Contributor

This backports d925e67 to pick up favicons and other files in the package distribution.

@jasongrout jasongrout changed the base branch from master to 1.0.x November 19, 2020 23:43
@codecov-io
Copy link

codecov-io commented Nov 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (1.0.x@37eac44). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             1.0.x     #347   +/-   ##
========================================
  Coverage         ?   66.96%           
========================================
  Files            ?       56           
  Lines            ?     5513           
  Branches         ?      716           
========================================
  Hits             ?     3692           
  Misses           ?     1593           
  Partials         ?      228           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37eac44...aec9947. Read the comment docs.

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging before tests finish, since this doesn't make any code changes.

@Zsailer Zsailer merged commit c7bbafc into jupyter-server:1.0.x Nov 19, 2020
@jasongrout
Copy link
Contributor Author

As an explanatory note, https://packaging.python.org/guides/using-manifest-in/#manifest-in-commands notes:

Setuptools also has undocumented support for ** matching zero or more characters including forward slash, backslash, and colon.

So we should not have been using ** all along, and just used the recursive-include that is officially supported.

Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
* tell the user that the sessions are syncing in the UI

* center syncing component on running tab

* if reconnecting after a missed heartbeat, clear the status

* ignore tests for running tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants