Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use setuptools find_packages, exclude tests, docs and examples from dist #368

Merged
merged 2 commits into from
Jan 4, 2021

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jan 2, 2021

This:

  • removes the confusing, deprecated find_packages from setupbase.py
  • imports and uses the real setuptools.find_packages to exclude things that might be python-module-like

In site-packages/, tests/, docs/, etc. are dumping grounds of all the packages that either don't use this flag. In this state, it's not even worth distributing them, as there's basically zero chance they'll work. Putting them in-tree, on the other hand, is very nice, as downstreams can ensure that their packages work, which helps catch issues sooner, but that's for another day...

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jan 2, 2021

oh, and we may need to add a temporary pin for jedi... ipython/ipython#12751

@codecov-io
Copy link

codecov-io commented Jan 2, 2021

Codecov Report

Merging #368 (e59b4ab) into master (1f5508e) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
+ Coverage   69.29%   69.30%   +0.01%     
==========================================
  Files          56       56              
  Lines        6135     6135              
  Branches      804      804              
==========================================
+ Hits         4251     4252       +1     
  Misses       1616     1616              
+ Partials      268      267       -1     
Impacted Files Coverage Δ
jupyter_server/services/kernels/handlers.py 58.51% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f5508e...e59b4ab. Read the comment docs.

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jan 2, 2021

Cool (i guess) looks like jedi's not breaking anything...

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes sense - thanks Nick. I'd prefer that someone more familiar with packaging/distribution than myself to review this as well prior to merging though.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit b4968ce into jupyter-server:master Jan 4, 2021
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
* update locks to jupyterlab 3.4.1

* print pip version
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
use setuptools find_packages, exclude tests, docs and examples from dist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants