Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle open_browser trait in ServerApp and ExtensionApp differently #375

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Handle open_browser trait in ServerApp and ExtensionApp differently #375

merged 1 commit into from
Jan 6, 2021

Conversation

afshin
Copy link
Contributor

@afshin afshin commented Jan 6, 2021

This adds a configurable open_browser trait to ExtensionApps, and refactors the ServerApp to handle browser-opening properly when another app, e.g. an ExtensionApp, starts the server.

This also adds a property, starter_app, to ServerApp that enables the ServerApp to know when an extension started the app (versus starting the server directly).

This will help address this issue seen in JupyterLab: jupyterlab/jupyterlab_server#145

A follow up PR in JupyterLab is needed to use this new trait.

@Zsailer
Copy link
Member

Zsailer commented Jan 6, 2021

👍 thanks, @afshin

@Zsailer Zsailer merged commit ec6217e into jupyter-server:master Jan 6, 2021
jasongrout added a commit to jasongrout/jupyterlab that referenced this pull request Jan 8, 2021
This follows on changes to Jupyter Server and ExtensionApp which moves open_browser to the ExtensionApp config.

See jupyter-server/jupyter_server#375

Fixes jupyterlab#9579
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
)

* Allow to get resourceDir from Notebook Service APIs

* Update data_studio_jupyter_extensions/configurables/kernelspecs.py

Co-authored-by: Zachary Sailer <zsailer@apple.com>

Co-authored-by: Zachary Sailer <zsailer@apple.com>
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Handle open_browser trait in ServerApp and ExtensionApp differently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants