Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Handling of the soft limit on open file handles #376

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Improve Handling of the soft limit on open file handles #376

merged 1 commit into from
Jan 7, 2021

Conversation

afshin
Copy link
Contributor

@afshin afshin commented Jan 6, 2021

@codecov-io
Copy link

codecov-io commented Jan 6, 2021

Codecov Report

Merging #376 (ea581ae) into master (ec6217e) will decrease coverage by 0.08%.
The diff coverage is 46.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
- Coverage   69.18%   69.09%   -0.09%     
==========================================
  Files          56       56              
  Lines        6166     6194      +28     
  Branches      811      816       +5     
==========================================
+ Hits         4266     4280      +14     
- Misses       1630     1641      +11     
- Partials      270      273       +3     
Impacted Files Coverage Δ
jupyter_server/serverapp.py 59.88% <46.42%> (-0.46%) ⬇️
jupyter_server/services/kernels/handlers.py 58.51% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec6217e...ea581ae. Read the comment docs.

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @afshin!

@Zsailer Zsailer merged commit 09cef16 into jupyter-server:master Jan 7, 2021
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
* add plugins for reconnecting to disconnected kernels

* allow user to restart the kernel heartbeat from the kernel menu

* remove dev print statement

* revert is_alive trigger used for testing reconnect dialog

* rename disconnectedkernel to noheartbeat

* update dependencY

* eventlistener singleton must be cleared in tests

* Update data_studio_jupyter_extensions/configurables/kernel_restarter.py

Co-authored-by: Andrey Velichkevich <a_velichkevich@apple.com>

* remove old debugging prints

Co-authored-by: Andrey Velichkevich <a_velichkevich@apple.com>
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Improve Handling of the soft limit on open file handles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants