Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable extensions to set debug and open-browser flags #379

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Enable extensions to set debug and open-browser flags #379

merged 1 commit into from
Jan 8, 2021

Conversation

afshin
Copy link
Contributor

@afshin afshin commented Jan 8, 2021

Configures both the ServerApp and Extension App when --debug and --no-browser is used.

This also fixes a minor issue when setting the _starter_app in ServerApp, that was causing JupyterLab's LabHubApp to fail.

@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #379 (abe6f93) into master (d4438a2) will increase coverage by 0.00%.
The diff coverage is 55.55%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #379   +/-   ##
=======================================
  Coverage   69.08%   69.08%           
=======================================
  Files          56       56           
  Lines        6194     6195    +1     
  Branches      816      816           
=======================================
+ Hits         4279     4280    +1     
  Misses       1641     1641           
  Partials      274      274           
Impacted Files Coverage Δ
jupyter_server/extension/application.py 62.30% <25.00%> (-0.47%) ⬇️
jupyter_server/serverapp.py 60.02% <80.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4438a2...abe6f93. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @afshin!

@Zsailer Zsailer merged commit ee88147 into jupyter-server:master Jan 8, 2021
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
…flags

Enable extensions to set debug and open-browser flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants