Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of sibling extensions #485

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Fix loading of sibling extensions #485

merged 1 commit into from
Apr 21, 2021

Conversation

afshin
Copy link
Contributor

@afshin afshin commented Apr 21, 2021

Prior to this change, an extension app either had to load all all extensions using load_other_extensions, or else only load itself. This change allows an extension app to declare a set of sibling extensions to load using serverapp_config.

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2021

Codecov Report

Merging #485 (0d11ffc) into master (8bfdd40) will increase coverage by 0.03%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
+ Coverage   77.69%   77.73%   +0.03%     
==========================================
  Files         106      106              
  Lines        9255     9269      +14     
  Branches      996      997       +1     
==========================================
+ Hits         7191     7205      +14     
  Misses       1707     1707              
  Partials      357      357              
Impacted Files Coverage Δ
jupyter_server/extension/application.py 72.68% <83.33%> (+0.18%) ⬆️
...pyter_server/tests/extension/mockextensions/app.py 90.00% <100.00%> (+0.34%) ⬆️
jupyter_server/tests/extension/test_app.py 100.00% <100.00%> (ø)
jupyter_server/serverapp.py 67.12% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bfdd40...0d11ffc. Read the comment docs.

@blink1073 blink1073 added this to the 1.6 milestone Apr 21, 2021
@blink1073 blink1073 added the bug label Apr 21, 2021
@blink1073 blink1073 merged commit 68a64ea into jupyter-server:master Apr 21, 2021
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants