Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a public property to sort extensions deterministically. #522

Merged
merged 1 commit into from
May 20, 2021

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented May 19, 2021

This provides a single, public property in the server extension API to return a deterministic list of server extensions.

This doesn't change much in server. We were already sorting extensions alphabetically by their keys. This change allows nbclassic to monkey-patch this property (as a special case) and provide a list of server extensions with nbclassic always first and the rest sorted alphabetically. See jupyter/nbclassic#56 for more details.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021

Codecov Report

Merging #522 (830e006) into master (6bf5914) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #522      +/-   ##
==========================================
- Coverage   76.99%   76.98%   -0.01%     
==========================================
  Files         107      107              
  Lines        9511     9499      -12     
  Branches     1032     1031       -1     
==========================================
- Hits         7323     7313      -10     
+ Misses       1815     1814       -1     
+ Partials      373      372       -1     
Impacted Files Coverage Δ
jupyter_server/services/config/manager.py 100.00% <ø> (ø)
jupyter_server/extension/manager.py 88.70% <100.00%> (+0.18%) ⬆️
jupyter_server/services/nbconvert/handlers.py 80.95% <0.00%> (-2.39%) ⬇️
...upyter_server/services/contents/filecheckpoints.py 62.94% <0.00%> (-0.65%) ⬇️
...pyter_server/services/contents/largefilemanager.py 82.41% <0.00%> (-0.57%) ⬇️
jupyter_server/services/contents/fileio.py 75.26% <0.00%> (-0.39%) ⬇️
jupyter_server/services/contents/filemanager.py 66.31% <0.00%> (-0.22%) ⬇️
jupyter_server/tests/extension/test_manager.py 100.00% <0.00%> (ø)
jupyter_server/tests/test_terminal.py 98.80% <0.00%> (+2.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 284c938...830e006. Read the comment docs.

@blink1073 blink1073 added this to the 1.8 milestone May 19, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Test failure looks to be related to a recent upstream release

@blink1073 blink1073 merged commit b063117 into jupyter-server:master May 20, 2021
@Zsailer Zsailer deleted the extension-manager branch January 16, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants