Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argon2 as an optional dependency #532

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

vidartf
Copy link
Member

@vidartf vidartf commented Jun 1, 2021

This is a follow up to #450.

In setups where passwords are not used, it is preferential to have argon2 be an optional dependency:

  • If not used, let us not import it (less resources)
  • argon2 has C-extensions, so it should ideally not be a hard requirement unless we can avoid it
  • This is also closer to how it was initially implemented in the notebook repository

It should still be a install requirement, as it is used by default.

In setups where passwords are not used, it is preferential to not have argon2 be an optional dependency:
- If not used, let us not import it
- argon2 has C-extensions, so it should ideally not be a hard requirement unless we can avoid it

It should still be a install requirement, as it is used by default, but pip allows you to side step that if you insist.
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2021

Codecov Report

Merging #532 (0a42f89) into master (19ab0a9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
+ Coverage   76.31%   76.33%   +0.02%     
==========================================
  Files         110      110              
  Lines        9809     9809              
  Branches     1067     1067              
==========================================
+ Hits         7486     7488       +2     
+ Misses       1943     1942       -1     
+ Partials      380      379       -1     
Impacted Files Coverage Δ
jupyter_server/auth/security.py 76.00% <100.00%> (ø)
jupyter_server/tests/services/kernels/test_api.py 99.01% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ab0a9...0a42f89. Read the comment docs.

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vidartf!

@Zsailer Zsailer merged commit 86b68e6 into jupyter-server:master Jun 1, 2021
@blink1073 blink1073 added this to the 1.9 milestone Jun 1, 2021
@vidartf vidartf deleted the argon-opt-dep branch June 2, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants