Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set stacklevel on warning to point to the right place. #572

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Aug 17, 2021

Without stacklevel=2, the warnings are a bit useless as we don't know
where the deprecated function is used.

Without stacklevel=2, the warnings are a bit useless as we don't know
where the deprecated function is used.
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #572 (e4a7ecf) into master (f914126) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
+ Coverage   76.87%   76.89%   +0.02%     
==========================================
  Files         109      109              
  Lines        9951     9951              
  Branches     1079     1079              
==========================================
+ Hits         7650     7652       +2     
+ Misses       1916     1915       -1     
+ Partials      385      384       -1     
Impacted Files Coverage Δ
jupyter_server/transutils.py 72.72% <0.00%> (ø)
jupyter_server/tests/services/kernels/test_api.py 99.01% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f914126...e4a7ecf. Read the comment docs.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch Matthias - thank you!

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Carreau! Tests are failing for unrelated issues

@Zsailer Zsailer merged commit 1444737 into jupyter-server:master Aug 17, 2021
@Carreau
Copy link
Contributor Author

Carreau commented Aug 17, 2021 via email

@Zsailer Zsailer added the bug label Aug 18, 2021
@blink1073 blink1073 added this to the 1.11 milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants