Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jupyter_client warning #581

Merged

Conversation

martinRenou
Copy link
Contributor

@martinRenou martinRenou commented Sep 9, 2021

Fix the jupyter_client warning:

/home/martin/miniconda3/envs/xeus-python/lib/python3.9/json/encoder.py:257: 
UserWarning: date_default is deprecated since jupyter_client 7.0.0. Use jupyter_client.jsonutil.json_default.

@martinRenou martinRenou force-pushed the fix_jupyter_client_warning branch from cee81d4 to cb37234 Compare September 9, 2021 08:56
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #581 (cb37234) into master (49d5772) will decrease coverage by 0.05%.
The diff coverage is 67.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
- Coverage   77.46%   77.41%   -0.06%     
==========================================
  Files         110      110              
  Lines       10184    10196      +12     
  Branches     1100     1100              
==========================================
+ Hits         7889     7893       +4     
- Misses       1907     1915       +8     
  Partials      388      388              
Impacted Files Coverage Δ
jupyter_server/services/kernels/handlers.py 61.55% <60.00%> (-0.23%) ⬇️
jupyter_server/base/zmqhandlers.py 60.00% <66.66%> (-0.55%) ⬇️
jupyter_server/services/contents/handlers.py 83.63% <71.42%> (-0.94%) ⬇️
jupyter_server/services/sessions/handlers.py 73.14% <75.00%> (-1.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d5772...cb37234. Read the comment docs.

@blink1073 blink1073 added this to the 1.10 milestone Sep 9, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 modified the milestones: 1.10, 1.11 Sep 9, 2021
@blink1073 blink1073 merged commit 1863fde into jupyter-server:master Sep 9, 2021
@martinRenou martinRenou deleted the fix_jupyter_client_warning branch September 9, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants