Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a pytest fixture for capturing logging stream #588

Merged
merged 2 commits into from
Oct 5, 2021

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Oct 4, 2021

Fixes #585.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2021

Codecov Report

Merging #588 (f3a5fa1) into master (ac93dd8) will decrease coverage by 0.15%.
The diff coverage is 91.30%.

❗ Current head f3a5fa1 differs from pull request most recent head c3a8d46. Consider uploading reports for the commit c3a8d46 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #588      +/-   ##
==========================================
- Coverage   77.47%   77.32%   -0.16%     
==========================================
  Files         110      110              
  Lines       10212    10250      +38     
  Branches     1104     1257     +153     
==========================================
+ Hits         7912     7926      +14     
- Misses       1910     1928      +18     
- Partials      390      396       +6     
Impacted Files Coverage Δ
jupyter_server/pytest_plugin.py 88.07% <77.77%> (-1.57%) ⬇️
jupyter_server/tests/services/kernels/test_api.py 97.02% <100.00%> (-1.95%) ⬇️
jupyter_server/tests/services/kernels/test_cull.py 100.00% <100.00%> (ø)
jupyter_server/tests/services/sessions/test_api.py 98.90% <100.00%> (+0.04%) ⬆️
jupyter_server/tests/test_terminal.py 98.75% <100.00%> (-0.05%) ⬇️
...yter_server/tests/services/kernelspecs/test_api.py 96.55% <0.00%> (-3.45%) ⬇️
jupyter_server/services/kernels/kernelmanager.py 79.79% <0.00%> (-2.06%) ⬇️
jupyter_server/services/kernels/handlers.py 60.92% <0.00%> (-1.55%) ⬇️
jupyter_server/utils.py 65.90% <0.00%> (-1.14%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac93dd8...c3a8d46. Read the comment docs.

@Zsailer Zsailer marked this pull request as draft October 4, 2021 19:00
@Zsailer Zsailer marked this pull request as ready for review October 4, 2021 19:52
@blink1073 blink1073 added the bug label Oct 5, 2021
@blink1073 blink1073 added this to the 1.11 milestone Oct 5, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit cc1b87c into jupyter-server:master Oct 5, 2021
@Zsailer Zsailer deleted the test-logging-stream branch January 16, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jp_serverapp pytest fixture clears all logging handlers
3 participants