Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Pass extension configuration to extension handlers #59

Merged
merged 2 commits into from
Jun 27, 2019
Merged

[MRG] Pass extension configuration to extension handlers #59

merged 2 commits into from
Jun 27, 2019

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Jun 26, 2019 •
edited
Loading

This PR makes it easier to pass extension config/settings to extension handlers.

Here, extension traits are collected in a Config object and added to the jupyter server's webapp settings. Extension handlers can access these settings through its self.config property using the . notation—e.g. self.config.some_setting.

@Zsailer Zsailer changed the title pass extension traits to extension handlers as config property Pass extension configuration to extension handlers Jun 26, 2019
@Zsailer Zsailer changed the title Pass extension configuration to extension handlers [MRG] Pass extension configuration to extension handlers Jun 26, 2019
@Zsailer Zsailer mentioned this pull request Jun 26, 2019
Closed
blink1073
blink1073 approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

rolweber
rolweber approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@rolweber rolweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rolweber rolweber merged commit bf029a5 into jupyter-server:master Jun 27, 2019
@Zsailer Zsailer mentioned this pull request Jul 10, 2019
Closed
@Zsailer Zsailer deleted the ext_config branch January 10, 2020 17:35
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
@Zsailer
add execute time extension (jupyter-server#59)
bbfbc6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolweber rolweber rolweber approved these changes

@blink1073 blink1073 blink1073 approved these changes

@SylvainCorlay SylvainCorlay Awaiting requested review from SylvainCorlay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zsailer @blink1073 @rolweber