Remove requests-unixsocket dependency #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #599 +/- ##
=======================================
Coverage 77.34% 77.34%
=======================================
Files 110 110
Lines 10250 10250
Branches 1257 1257
=======================================
Hits 7928 7928
Misses 1926 1926
Partials 396 396 Continue to review full report at Codecov.
|
This was referenced Nov 1, 2021
|
@kevin-bates, do you mind rebasing to pick up the changes in #601? |
kevin-bates
force-pushed
the
remove-requests_unixsocket-dependency
branch
from
3d37a04 to
9eeb55d
Compare
Zsailer
approved these changes
Nov 1, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unix socket support was ported from Notebook which has a test that uses
requests-unixsocketto test the functionality. Later, we updated the Notebook test to use a lazy import so we could remove this dependency on Windows.The tests within jupyter_server are quite different and it appears, based on the successful tests, that this dependency isn't required at all. I'm sure it was just an artifact from the original port. This pull request removes the dependency.
Fixes: #598