Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jpserver_extensions trait to work with traitlets 5.x #610

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Nov 11, 2021

Fixes #606

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #610 (fb3ec89) into master (a1b013e) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #610      +/-   ##
==========================================
- Coverage   77.41%   77.39%   -0.02%     
==========================================
  Files         110      110              
  Lines       10252    10252              
  Branches     1259     1259              
==========================================
- Hits         7937     7935       -2     
- Misses       1918     1919       +1     
- Partials      397      398       +1     
Impacted Files Coverage Δ
jupyter_server/serverapp.py 65.47% <ø> (ø)
jupyter_server/tests/services/kernels/test_api.py 97.02% <0.00%> (-1.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b013e...fb3ec89. Read the comment docs.

@Zsailer Zsailer requested a review from mwakaba2 November 12, 2021 17:35
@Zsailer Zsailer added the bug label Nov 12, 2021
Copy link
Member

@mwakaba2 mwakaba2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zach! I confirmed it's working!

$ jupyter server -ServerApp.jpserver_extensions "jupyterlab"=True
[I 2021-11-14 21:40:06.895 ServerApp] jupyterlab | extension was successfully linked.

@Zsailer Zsailer merged commit 6c8c923 into jupyter-server:master Nov 15, 2021
@blink1073 blink1073 added this to the 1.12 milestone Nov 23, 2021
@Zsailer Zsailer deleted the jpserver-extension-traittype branch January 16, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyter Server CLI can't accept server extensions as key value items.
4 participants