Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set xsrf cookie on base url #612

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Nov 18, 2021

avoids collisions across a given host

closes jupyterhub/jupyterhub#3624

avoids collisions across a given host
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #612 (9619019) into master (6c8c923) will increase coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
+ Coverage   77.36%   77.39%   +0.03%     
==========================================
  Files         110      110              
  Lines       10252    10254       +2     
  Branches     1259     1260       +1     
==========================================
+ Hits         7931     7936       +5     
+ Misses       1926     1919       -7     
- Partials      395      399       +4     
Impacted Files Coverage Δ
jupyter_server/serverapp.py 65.44% <50.00%> (-0.03%) ⬇️
jupyter_server/tests/services/kernels/test_api.py 97.02% <0.00%> (-1.99%) ⬇️
jupyter_server/services/kernels/kernelmanager.py 81.84% <0.00%> (+2.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8c923...9619019. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_xsrf cookie for singleuser server not scoped to the base_url
4 participants