Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

await _finish_kernel_start #617

Merged
merged 2 commits into from
Nov 26, 2021
Merged

await _finish_kernel_start #617

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
928f8b2
await _finish_kernel_start
jtpio Nov 26, 2021
005e783
Guard with use_pending_kernels
jtpio Nov 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion jupyter_server/services/kernels/kernelmanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,9 @@ async def start_kernel(self, kernel_id=None, path=None, **kwargs):
kwargs["kernel_id"] = kernel_id
kernel_id = await ensure_async(self.pinned_superclass.start_kernel(self, **kwargs))
self._kernel_connections[kernel_id] = 0
asyncio.ensure_future(self._finish_kernel_start(kernel_id))
fut = asyncio.ensure_future(self._finish_kernel_start(kernel_id))
if not getattr(self, "use_pending_kernels", None):
await fut
# add busy/activity markers:
kernel = self.get_kernel(kernel_id)
kernel.execution_state = "starting"
Expand Down