Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't block the event loop when exporting with nbconvert #655

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

davidbrochart
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2022

Codecov Report

Merging #655 (e0171ae) into main (db46446) will increase coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
+ Coverage   77.88%   77.94%   +0.05%     
==========================================
  Files         110      110              
  Lines       10405    10406       +1     
  Branches     1400     1400              
==========================================
+ Hits         8104     8111       +7     
+ Misses       1911     1907       -4     
+ Partials      390      388       -2     
Impacted Files Coverage Δ
jupyter_server/nbconvert/handlers.py 25.00% <50.00%> (+0.72%) ⬆️
jupyter_server/services/kernels/handlers.py 62.71% <0.00%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db46446...e0171ae. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit f3b6340 into jupyter-server:main Jan 11, 2022
@davidbrochart davidbrochart deleted the async_nbconvert branch January 11, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants