Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More updates to unit tests for pending kernels work #662

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Jan 14, 2022

This is a follow-up PR to #654. The session unit tests also need to changes for the work landing in Jupyter Client around pending kernels.

@Zsailer
Copy link
Member Author

Zsailer commented Jan 14, 2022

The await session_client.cleanup() is no longer needed because await jp_cleanup_subprocesses() handles cleanup.

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

Merging #662 (e618ea5) into main (db46446) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
- Coverage   77.88%   77.80%   -0.09%     
==========================================
  Files         110      110              
  Lines       10405    10415      +10     
  Branches     1400     1401       +1     
==========================================
- Hits         8104     8103       -1     
- Misses       1911     1924      +13     
+ Partials      390      388       -2     
Impacted Files Coverage Δ
jupyter_server/tests/services/sessions/test_api.py 96.59% <100.00%> (-1.58%) ⬇️
jupyter_server/services/kernels/kernelmanager.py 80.63% <0.00%> (-1.91%) ⬇️
jupyter_server/tests/services/kernels/test_api.py 96.37% <0.00%> (+0.37%) ⬆️
jupyter_server/nbconvert/handlers.py 25.00% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db46446...e618ea5. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 507496c into jupyter-server:main Jan 14, 2022
@Zsailer Zsailer deleted the pending-unit-tests branch January 16, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants