Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make unit tests backwards compatible without pending kernels #669

Merged
merged 8 commits into from
Jan 24, 2022

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Jan 18, 2022

Fixes #666.

@Zsailer Zsailer added the bug label Jan 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #669 (bb047b4) into main (d3bc6bf) will increase coverage by 0.09%.
The diff coverage is 90.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
+ Coverage   77.79%   77.88%   +0.09%     
==========================================
  Files         110      110              
  Lines       10409    10456      +47     
  Branches     1399     1402       +3     
==========================================
+ Hits         8098     8144      +46     
+ Misses       1922     1920       -2     
- Partials      389      392       +3     
Impacted Files Coverage Δ
jupyter_server/pytest_plugin.py 84.16% <54.54%> (-1.68%) ⬇️
jupyter_server/tests/services/sessions/test_api.py 96.61% <97.82%> (+0.02%) ⬆️
jupyter_server/tests/services/kernels/test_api.py 95.13% <100.00%> (+0.24%) ⬆️
jupyter_server/tests/services/kernels/test_cull.py 100.00% <100.00%> (ø)
jupyter_server/utils.py 65.90% <0.00%> (-0.57%) ⬇️
jupyter_server/services/kernels/kernelmanager.py 82.53% <0.00%> (+1.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3bc6bf...bb047b4. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073
Copy link
Contributor

We need to remove this config and instead add the argument to the test invocations in the workflows, since we no longer support doctest in the link check job

@Zsailer
Copy link
Member Author

Zsailer commented Jan 18, 2022

@blink1073, thanks! done 👍

pyproject.toml Outdated
@@ -9,7 +9,6 @@ factory = "jupyter_packaging.npm_builder"
ignore = ["tbump.toml", ".*", "*.yml", "package-lock.json", "bootstrap*", "conftest.py"]

[tool.pytest.ini_options]
addopts = "--doctest-modules"
Copy link
Contributor

@blink1073 blink1073 Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can revert the doctest-related changes, we fixed this in jupyter-server/jupyter_releaser#246

@blink1073
Copy link
Contributor

We picked up a couple merge conflicts from #673

@blink1073 blink1073 merged commit ad0f710 into jupyter-server:main Jan 24, 2022
@Zsailer Zsailer deleted the unit-test-bug branch January 16, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests in version 1.13.3 need jupyter_client 7.1
3 participants