Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auto Pre-Commit #685

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Feb 2, 2022

Experimental support for running pre-commit on a PR.

With this configuration, any member, owner, or collaborator can comment auto run pre-commit, and it will run pre-commit against the PR and push the change.

For now, we use the GITHUB_TOKEN provided to the workflow.
The result is that the workflows are not automatically re-run for the commit: we have to close and re-open the PR.

We can later decide to use an access token from @jupyterlab-bot, which would re-run the workflows.

The end state is that we will ideally use jupyterlab-probot for this feature once it is available there.

This gives us a chance to kick the tires on the concept with minimal risk.

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do you want to merge this before Thursday's meeting to try it out?

@blink1073
Copy link
Contributor Author

Yeah, let's go for it!

@blink1073 blink1073 merged commit 8190db9 into jupyter-server:main Feb 2, 2022
@blink1073 blink1073 deleted the add-pre-commit-runner branch February 2, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants