Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server extension paths #730

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Mar 14, 2022

re-issue #715 with fixes and test for case not handled where ExtensionApps can be instantiated and loaded without being Extensions (#727).

minrk added 3 commits March 14, 2022 13:07
This property in the base class already has the same logic to add config_dir to jupyter_config_path

JupyterHub overrides this to have slightly different logic, and the same should apply here
base ServerApp should have total control over config file loading
Shouldn't ever be accessed without assignment,
but may in cases where ExtensionApps skip initialization and loads config directly
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 9711822 into jupyter-server:main Mar 14, 2022
@minrk minrk deleted the server_extension_paths branch March 14, 2022 13:40
blink1073 added a commit to blink1073/jupyter_server that referenced this pull request Mar 14, 2022
blink1073 added a commit that referenced this pull request Mar 14, 2022
minrk added a commit to minrk/jupyter_server that referenced this pull request Mar 14, 2022
minrk added a commit to minrk/jupyter_server that referenced this pull request Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants