-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mypy check #779
Add mypy check #779
Conversation
Codecov Report
@@ Coverage Diff @@
## main #779 +/- ##
==========================================
- Coverage 70.21% 70.12% -0.10%
==========================================
Files 63 63
Lines 7494 7544 +50
Branches 1258 1258
==========================================
+ Hits 5262 5290 +28
- Misses 1851 1873 +22
Partials 381 381
Continue to review full report at Codecov.
|
I think this is going to cause some pain for other PRs that will need to rebase. Maybe we should wait until (at least) identity is merged? |
Sounds fair, will mark as 2.0 |
faefd26
to
b3a3336
Compare
This is ready now |
add py.typed file use typings from jupyter_client fix typing fix gateway tests
I plan to merge this and cut the first alpha release tomorrow. |
Do you think we should backport these changes? I ask, because if we merge this and don't backport it, do you think it will cause issues for future backports? It seems like future backports might have conflicts with changes here and cause meeseeks to choke. |
Good point, I'll take care of the backporting of this one. |
@meeseeksdev please backport to 1.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
(cherry picked from commit 3e64fa5)
(cherry picked from commit 3e64fa5)
Minimal typings support, mostly as a linter for now.
Uses new typings from
jupyter_client
.I'm working on shipping minimal typings with traitlets and jupyter_core as well.