Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing required arguments in utils.fetch #798

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Apr 25, 2022

all arguments except the url were being ignored in utils.fetch, meanign all POST requests, authorized requests, etc. would fail

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022

Codecov Report

Merging #798 (c3a7775) into main (ef1deca) will decrease coverage by 0.14%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
- Coverage   70.04%   69.89%   -0.15%     
==========================================
  Files          62       62              
  Lines        7368     7368              
  Branches     1223     1223              
==========================================
- Hits         5161     5150      -11     
- Misses       1831     1845      +14     
+ Partials      376      373       -3     
Impacted Files Coverage Δ
jupyter_server/serverapp.py 65.11% <0.00%> (ø)
jupyter_server/utils.py 61.38% <50.00%> (ø)
jupyter_server/base/zmqhandlers.py 52.40% <0.00%> (-2.68%) ⬇️
jupyter_server/services/kernels/handlers.py 57.44% <0.00%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef1deca...c3a7775. Read the comment docs.

@minrk minrk added the bug label Apr 25, 2022
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 49e926d into jupyter-server:main Apr 25, 2022
@blink1073
Copy link
Contributor

@meeseeksdev please backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyter_server that referenced this pull request Apr 25, 2022
blink1073 pushed a commit that referenced this pull request Apr 25, 2022
…etch) (#799)

Co-authored-by: Min RK <benjaminrk@gmail.com>
@minrk minrk deleted the required-fetch-args branch May 4, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants