-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document the logging_config trait #844
Conversation
I think depending on traitlets >= 5.2.1 sounds good, since this is targeting 2.0 |
Codecov ReportBase: 75.14% // Head: 75.14% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
=======================================
Coverage 75.14% 75.14%
=======================================
Files 63 63
Lines 8225 8225
Branches 1635 1635
=======================================
Hits 6181 6181
Misses 1624 1624
Partials 420 420 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bf98a13
to
2c3ed41
Compare
for more information, see https://pre-commit.ci
(deconflicted) |
I pushed a change to increase the minimum to 5.3, since I had some difficulties with the 5.2.x traitlets releases 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much!
Addresses #684
(will fail CI until Traitlets5.2.1
is released)5.1
to5.2.1
(not yet released).logging_config
trait.logging_config
with Jupyter Server / extension applications.