suppress tornado deprecation warnings #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter_server
that referenced
this pull request
Jun 22, 2022
blink1073
pushed a commit
that referenced
this pull request
Jun 22, 2022
#889) Co-authored-by: Min RK <benjaminrk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should get tests tests passing with tornado 6.2
tornado's following asyncio's lead in deprecating the concept of a 'current' event loop that's not running. This mostly affects our initialization/event-loop-starting code which is in
serverapp.pyand the test fixtures (largely in pytest-tornasync), since the event loop's running for everything else.Rather than fully hiding the warnings, just avoid errors (I treated the equivalent asyncio warning the same). It's still useful info to know the warnings are being triggered.
We can use #876 to track avoiding these deprecations