-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for serverapp for reraise flag #887
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The supporting serverextension apps (enable/disable/list) should probably always complete even if an exception raises an error, so in those cases, default to just warning about exceptions, but still complete.
Codecov Report
@@ Coverage Diff @@
## main #887 +/- ##
==========================================
- Coverage 72.15% 72.12% -0.03%
==========================================
Files 65 65
Lines 8044 8044
Branches 1343 1343
==========================================
- Hits 5804 5802 -2
- Misses 1835 1836 +1
- Partials 405 406 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
It should not raise exceptions if there is no serverapp.
for more information, see https://pre-commit.ci
Zsailer
approved these changes
Aug 29, 2022
Thanks, @vidartf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The secondary serverextension apps (enable/disable/list) should probably always complete even if an extension raises an error, so in those cases, default to just warning about exceptions, but still complete.
Fixes #676
Note: Not tested locally, just edited via GH interface. I'd prefer to add a regression test as well if I have time.