Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #913 on branch 1.x (Fix handling of dev version) #914

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #913: Fix handling of dev version

@codecov-commenter
Copy link

Codecov Report

Merging #914 (4c9a51b) into 1.x (04b197d) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              1.x     #914      +/-   ##
==========================================
- Coverage   71.64%   71.50%   -0.15%     
==========================================
  Files          62       62              
  Lines        7686     7686              
  Branches     1275     1272       -3     
==========================================
- Hits         5507     5496      -11     
- Misses       1790     1796       +6     
- Partials      389      394       +5     
Impacted Files Coverage Δ
jupyter_server/services/kernels/handlers.py 57.80% <0.00%> (-0.85%) ⬇️
jupyter_server/services/contents/filemanager.py 71.40% <0.00%> (-0.80%) ⬇️
jupyter_server/base/zmqhandlers.py 53.43% <0.00%> (-0.53%) ⬇️
jupyter_server/serverapp.py 65.24% <0.00%> (-0.19%) ⬇️
jupyter_server/base/handlers.py 65.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04b197d...4c9a51b. Read the comment docs.

@blink1073 blink1073 merged commit 98db236 into jupyter-server:1.x Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants