Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded client install #991

Merged
merged 1 commit into from
Sep 25, 2022

Conversation

blink1073
Copy link
Contributor

Follow up to #988

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2022

Codecov Report

Base: 72.60% // Head: 72.54% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (0679984) compared to base (c88846c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
- Coverage   72.60%   72.54%   -0.07%     
==========================================
  Files          64       64              
  Lines        8243     8243              
  Branches     1378     1378              
==========================================
- Hits         5985     5980       -5     
- Misses       1844     1848       +4     
- Partials      414      415       +1     
Impacted Files Coverage Δ
jupyter_server/services/kernels/handlers.py 57.68% <0.00%> (-1.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit c49df47 into jupyter-server:main Sep 25, 2022
@blink1073 blink1073 deleted the remove-hardcoded-client branch September 25, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants