Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle TimeoutError During Fixture Shutdown #40

Merged
merged 3 commits into from
Dec 18, 2022

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Dec 18, 2022

Fixes #39

@blink1073 blink1073 added the bug Something isn't working label Dec 18, 2022
@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Base: 94.50% // Head: 94.18% // Decreases project coverage by -0.32% ⚠️

Coverage data is based on head (d83c5b6) compared to base (d6216bd).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   94.50%   94.18%   -0.33%     
==========================================
  Files          12       12              
  Lines         510      516       +6     
==========================================
+ Hits          482      486       +4     
- Misses         28       30       +2     
Impacted Files Coverage Δ
pytest_jupyter/jupyter_server.py 92.51% <50.00%> (-0.71%) ⬇️
tests/test_jupyter_server.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073
Copy link
Contributor Author

So it looks like the issue isn't caused by this library, but we can handle the timeout if it does happen.

@blink1073 blink1073 changed the title Try a skip Handle TimeoutError During Fixture Shutdown Dec 18, 2022
@blink1073 blink1073 enabled auto-merge (squash) December 18, 2022 01:52
@blink1073 blink1073 merged commit 5e9a4dd into jupyter-server:main Dec 18, 2022
@blink1073 blink1073 deleted the fix-skip branch December 18, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest.skip causes tests to fail on cleanup
1 participant