Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release instructions with additonal commit steps #52

Merged

Conversation

kevin-bates
Copy link
Member

In building the 0.7.0 release, there seemed to be some missing steps, primarily around the commit(s) of the (twice) updated _version.py file. It also includes the v prefix on the tag name (to be consistent with existing tags) - along with its push.

Another area I wasn't sure about was the authoring of the Release itself. I used the Generate release notes button to build the content, then added the contributors and full change log entries.

Also, I wasn't sure where the assets (assets_shas.json and metadata.json) come from, so not sure if their generation should be addressed in the instructions as well. Note that the 0.7.0 does NOT current include those assets.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f874ec6) 94.35% compared to head (59eaac4) 94.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files          12       12           
  Lines         514      514           
=======================================
  Hits          485      485           
  Misses         29       29           
Impacted Files Coverage Δ
pytest_jupyter/_version.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 7301417 into jupyter-server:main Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants