Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch #225

Merged
merged 9 commits into from
Nov 17, 2021
Merged

Batch #225

merged 9 commits into from
Nov 17, 2021

Conversation

DerThorsten
Copy link
Contributor

  • added batch API for pybox2d
  • this is not fitting very well to the existing batch api since we also pass an array of colors
  • might need refactoring

martinRenou
martinRenou reviewed Nov 16, 2021
View reviewed changes
Copy link
Collaborator

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice!! Thanks :)

I haven't tested yet, but I have some comments:

ipycanvas/canvas.py Outdated Show resolved Hide resolved
src/widget.ts Outdated Show resolved Hide resolved
src/widget.ts Outdated Show resolved Hide resolved
@DerThorsten DerThorsten marked this pull request as ready for review November 17, 2021 12:48
martinRenou
martinRenou reviewed Nov 17, 2021
View reviewed changes
Copy link
Collaborator

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looking pretty good :)

batch.ipynb Outdated Show resolved Hide resolved
examples/batch_drawing.ipynb Outdated Show resolved Hide resolved
examples/batch_drawing.ipynb Outdated Show resolved Hide resolved
examples/batch_drawing.ipynb Outdated Show resolved Hide resolved
@martinRenou
Copy link
Collaborator

We should document those new methods in a follow-up PR

DerThorsten and others added 3 commits November 17, 2021 15:54
@DerThorsten @martinRenou
Update examples/batch_drawing.ipynb
40b66a5 
Co-authored-by: martinRenou <martin.renou@gmail.com>
@DerThorsten @martinRenou
Update examples/batch_drawing.ipynb
d18f581 
Co-authored-by: martinRenou <martin.renou@gmail.com>
@DerThorsten @martinRenou
Update examples/batch_drawing.ipynb
c5d6be2 
Co-authored-by: martinRenou <martin.renou@gmail.com>
@DerThorsten
Copy link
Contributor Author

@martinRenou the "Test / build" part of the CI fails with some python 3.10 related error in jupyter_packaging
https://github.com/martinRenou/ipycanvas/runs/4239573498?check_suite_focus=true#step:4:16

@DerThorsten
Copy link
Contributor Author

We should document those new methods in a follow-up PR

I can also update the docs in this if you prefer that =)

@martinRenou
Copy link
Collaborator

It's fine in another PR :)

@martinRenou
Copy link
Collaborator

We'll need to update jupyter-packaging I guess... But let's do that in a separate PR too. Thanks!

@martinRenou martinRenou merged commit d845664 into jupyter-widgets-contrib:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DerThorsten @martinRenou