-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not share the Expr for text_color and background_color #400
fix: do not share the Expr for text_color and background_color #400
Conversation
a553265
to
6724ab0
Compare
Originally introduced in #35 by @martinRenou |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
8c1a899
to
f6c56a3
Compare
The commit I made from the Github interface has not been signed off, sorry for that! You will probably need to edit that commit (maybe you can also squash all commits into a single signed off one) |
f6c56a3
to
a7e5cd1
Compare
ok, squashed them, but needs you approval again :) |
a7e5cd1
to
3532b3b
Compare
Looks like this collides with this https://github.com/jupyter-widgets/ipywidgets/pull/3358/files |
It's odd that we did not hit that before. PRs were green a couple of weeks ago. Thanks for the pointer! I agree we should probably fix master first. |
Signed-off-by: Maarten A. Breddels <maartenbreddels@gmail.com>
3532b3b
to
405b268
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Every TextRenderer shares the same
Expr
(by default). This means that if I create two text renderers, and change the expression on one, it also changes the expression in the other TextRenderer.e.g.I think this should behave analogous to say a
.layout
widget, where they are not shared.To be honest, this is not the original reason to create this PR. In solara, we cannot have widgets created at import time, since each user would share the same widget, which breaks ipydatagrid in solara.
I hope one of the two reasons is compelling enough :)