Merge pull request #3365 from jasongrout/round

Validate selection slider values
jupyter-widgets · Feb 1, 2022 · 11ade00 · 11ade00
2 parents 29b58ea + 05f63a0
commit 11ade00
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/controls/src/widget_int.ts b/packages/controls/src/widget_int.ts
@@ -219,7 +219,7 @@ export abstract class BaseIntSliderView extends DescriptionView {
       direction: orientation === 'horizontal' ? 'ltr' : 'rtl',
       format: {
         from: (value: string): number => Number(value),
-        to: (value: number): number => value,
+        to: (value: number): number => this._validate_slide_value(value),
       },
     });
 
@@ -285,7 +285,7 @@ export abstract class BaseIntSliderView extends DescriptionView {
    * and applying it to the other views on the page.
    */
   _validate_slide_value(x: number): number {
-    return Math.floor(x);
+    return Math.round(x);
   }
 
   $slider: any;

diff --git a/packages/controls/src/widget_selection.ts b/packages/controls/src/widget_selection.ts
@@ -765,7 +765,7 @@ export class SelectionSliderView extends DescriptionView {
       direction: orientation === 'horizontal' ? 'ltr' : 'rtl',
       format: {
         from: (value: string): number => Number(value),
-        to: (value: number): number => value,
+        to: (value: number): number => Math.round(value),
       },
     });