Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak some typings #3554

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Tweak some typings #3554

merged 1 commit into from
Aug 26, 2022

Conversation

vidartf
Copy link
Member

@vidartf vidartf commented Aug 19, 2022

Widen the types of some methods. Using BufferJSON will allow objects with DataViews to be passed.

@vidartf
Tweak some typings
84bf538 
Widen the types of some methods. Using `BufferJSON` will allow objects with `DataView`s to be passed.
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch vidartf/ipywidgets/use-buffer-json

@vidartf vidartf modified the milestones: 8.1, Patch release Aug 19, 2022
@jasongrout
Copy link
Member

Is this a bugfix you need in 8.0.x for something you are doing?

@vidartf
Copy link
Member Author

vidartf commented Aug 22, 2022

@jasongrout It is preventing me from passing valid data to _deserialize_state in some tests without casting to any. E.g. https://github.com/vidartf/ipydatawidgets/blob/51ed3ec0b469f79222df62abd6a399e9fd0ae7db/packages/jupyter-datawidgets/tests/src/common.spec.ts#L21-L32

@jtpio jtpio mentioned this pull request Aug 25, 2022
Open
@jasongrout jasongrout merged commit 2d9f0a9 into jupyter-widgets:master Aug 26, 2022
@vidartf vidartf deleted the use-buffer-json branch August 26, 2022 13:59
This was referenced Aug 26, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg:base
Projects
None yet
Milestone
Patch release
Development

Successfully merging this pull request may close these issues.
2 participants
@vidartf @jasongrout