Automatically set public path #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'auto' setting should automatically choose the correct public path, depending on where the js file was loaded from. This removes the difference between the classic notebook extension bundle and the CDN bundle, so we also consolidated the two webpack targets.
jasongrout
added a commit
to jasongrout/ipyleaflet
that referenced
this pull request
Jun 2, 2022
This means the files should be able to be hosted on any CDN. Also update the webpack image loaders to use the new asset/resource type. See also jupyter-widgets/ipywidgets#3464 and jupyter-widgets/widget-cookiecutter#103
It seems that the auto public path logic in webpack does not work for AMD modules, since document.currentScript only works when the script is initially executed, not in a callback. In the cases where we know we are compiling to an AMD module, we can use the requirejs magic 'module' dependency to get the url of the file, and from that do our own auto public path magic. We encapsulate this auto public path setting into its own file so that it does not intrude on user code, and is only used when we know in the webpack config that we are compiling to an AMD module.
jasongrout
added a commit
to jasongrout/ipyleaflet
that referenced
this pull request
Jun 2, 2022
It seems that the auto public path logic in webpack does not work for AMD modules, since document.currentScript only works when the script is initially executed, not in a callback. In the cases where we know we are compiling to an AMD module, we can use the requirejs magic 'module' dependency to get the url of the file, and from that do our own auto public path magic. We encapsulate this auto public path setting into its own file so that it does not intrude on user code, and is only used when we know in the webpack config that we are compiling to an AMD module. See also jupyter-widgets/widget-cookiecutter#103
This was referenced Jun 2, 2022
6 tasks
Yes, they need to go two different places: the python package for the classic notebook extension, and the npm dist folder for CDN. You're right that we could just create the bundle once and then copy the bundle and other associated files to the other place. It's easier and simpler configuration to have webpack generate it twice, though. |
|
I don't think webpack can do that out of the box btw (googled that a few days ago), it probably requires some extra 'post' script. |
|
I think I've used https://webpack.js.org/plugins/copy-webpack-plugin/ before for copying files. |
ctOSKalle
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another attempt to automatically set the public path, this time using the requirejs magic 'module' dependency. This removes the need to hardcode public paths when compiling to AMD modules, and makes it possible to host the AMD module on any server (and does not hardcode the CDN).
This removes the difference between the classic notebook extension bundle and the CDN bundle, so we also consolidated the two webpack targets.