Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Add openpyxl to scipy-notebook to support .xlsx Excel files #1804

Closed
dietmar opened this issue Oct 12, 2022 · 0 comments · Fixed by #1805
Closed

[ENH] - Add openpyxl to scipy-notebook to support .xlsx Excel files #1804

dietmar opened this issue Oct 12, 2022 · 0 comments · Fixed by #1805
Labels
type:Enhancement A proposed enhancement to the docker images

Comments

@dietmar
Copy link
Contributor

dietmar commented Oct 12, 2022

What docker image(s) is this feature applicable to?

scipy-notebook

What changes are you proposing?

Add the openpyxl package to the image.

Currently, the pandas function read_excel can only read old-style .xls files but not new-style .xlsx files, because the scipy-notebook image does contain the package xlrd, but not openpyxl.
Since pandas 1.3.0, read_excel uses xlrd for old-style .xls files only, for new-style .xlsx files openpyxl is required, see the following links:

How does this affect the user?

"New-style" .xlsx files are IMO very common (and more common than .xls these days), so including the capability to work with such files per default makes a lot of sense.

The scipy-notebook image seems the right place for this, because this is where all the Python dependencies are added (such as xlrd). Initially I came across this issue using the datascience-notebook image, but that is based off scipy-notebook.

Anything else?

I'll be working on a pull request myself right away.

@dietmar dietmar added the type:Enhancement A proposed enhancement to the docker images label Oct 12, 2022
dietmar pushed a commit to dietmar/docker-stacks that referenced this issue Oct 12, 2022
dietmar pushed a commit to dietmar/docker-stacks that referenced this issue Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Enhancement A proposed enhancement to the docker images
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant