Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add octave notebook with popular packages #1204

Closed
wants to merge 2 commits into from

Conversation

expelledboy
Copy link

No description provided.

@romainx
Copy link
Collaborator

romainx commented Dec 29, 2020

Hello @expelledboy,

Thanks for this PR. However we are sorry but we are not extending the core stack with new images, that takes instead the community images path. Here is a recent comment explaining this process.

We've been requesting that all new image definitions take the community images path, primarily because this repository is unwieldy and we're already finding it difficult to maintain the images that already exist here. It sounds like you already have a nice project setup for building the images. Would you be open to submitting a pull request linking to it from the documentation instead of this PR?

Best.

@romainx romainx added the tag:Community Stack We recommend this contribution become a community stack. label Dec 29, 2020
@romainx
Copy link
Collaborator

romainx commented Jan 7, 2021

Hello @expelledboy,

According to my last comment, I'm closing this PR. We hope you will go through the community images path since this notebook is interesting. Do not hesitate to ping us if you are stuck.

Best.

@romainx romainx closed this Jan 7, 2021
@expelledboy
Copy link
Author

No worries, thanks for the info! I will see about migrating the image across

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:Community Stack We recommend this contribution become a community stack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants