Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nteract front end #1327

Closed
wants to merge 2 commits into from
Closed

Add nteract front end #1327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc578c4
Merge branch 'master' of https://github.com/willpuckett/docker-stacks
willpuckett May 23, 2021
5f12d6d
Add Nteract Frontend
willpuckett May 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ in working on the project.
## Jupyter Notebook Deprecation Notice

Following [Jupyter Notebook notice](https://github.com/jupyter/notebook#notice), we encourage users to transition to JupyterLab.
This can be done by passing the environment variable `JUPYTER_ENABLE_LAB=yes` at container startup,
more information is available in the [documentation](https://jupyter-docker-stacks.readthedocs.io/en/latest/using/common.html#docker-options).
This can be done by passing the environment variable `JUPYTER_ENABLE_LAB=yes` at container startup. Alternatively, you may pass the environment variable `NTERACT=yes` to use the [nteract](https://blog.nteract.io/nteract-on-jupyter-53cc2c38290d) front end. More information is available in the [documentation](https://jupyter-docker-stacks.readthedocs.io/en/latest/using/common.html#docker-options).

At some point, JupyterLab will become the default for all of the Jupyter Docker stack images, however a new environment variable will be introduced to switch back to Jupyter Notebook if needed.

Expand Down
5 changes: 3 additions & 2 deletions base-notebook/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ RUN wget --quiet "https://github.com/conda-forge/miniforge/releases/download/${m
fix-permissions $CONDA_DIR && \
fix-permissions /home/$NB_USER

# Install Jupyter Notebook, Lab, and Hub
# Install Jupyter Notebook, Lab, nteract, and Hub
# Generate a notebook server config
# Cleanup temporary files
# Correct permissions
Expand All @@ -132,7 +132,8 @@ RUN wget --quiet "https://github.com/conda-forge/miniforge/releases/download/${m
RUN conda install --quiet --yes \
'notebook=6.3.0' \
'jupyterhub=1.4.1' \
'jupyterlab=3.0.15' && \
'jupyterlab=3.0.15' \
'nteract_on_jupyter=2.1.3' && \
conda clean --all -f -y && \
npm cache clean --force && \
jupyter notebook --generate-config && \
Expand Down
2 changes: 2 additions & 0 deletions base-notebook/start-notebook.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ if [[ -n "${JUPYTERHUB_API_TOKEN}" ]]; then
elif [[ -n "${JUPYTER_ENABLE_LAB}" ]]; then
# shellcheck disable=SC1091
. /usr/local/bin/start.sh $wrapper jupyter lab "$@"
elif [[ -n "${NTERACT}" ]]; then
. /usr/local/bin/start.sh $wrapper jupyter nteract "$@"
else
echo "WARN: Jupyter Notebook deprecation notice https://github.com/jupyter/docker-stacks#jupyter-notebook-deprecation-notice."
# shellcheck disable=SC1091
Expand Down