Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the base & minimal notebook containers not amd specific (e.g. support building for arm64) #1368

Merged
merged 16 commits into from
Jul 8, 2021
Merged

Make the base & minimal notebook containers not amd specific (e.g. support building for arm64) #1368

merged 16 commits into from
Jul 8, 2021

Commits on Jul 6, 2021

  1. Dynamically select the right miniforge arch and unpin the ROOT_CONTAI… 

    …NER so that buildx can build arm64 and amd64

cleanup
    @holdenk
    holdenk committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    5ce5888 View commit details
    Browse the repository at this point in the history

  2. Remove the commented out hard set of arch

    @holdenk
    holdenk committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    5a125bd View commit details
    Browse the repository at this point in the history

  3. Address code review comments from mathbunnyru

    @holdenk
    holdenk committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    e6a4667 View commit details
    Browse the repository at this point in the history

  4. Add setting the owner to respective dockerhbub username

    @holdenk
    holdenk committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    3b7d143 View commit details
    Browse the repository at this point in the history

  5. Revert "Add setting the owner to respective dockerhbub username" 

    This reverts commit a8d9c46.
    @holdenk
    holdenk committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    ec579fa View commit details
    Browse the repository at this point in the history

  6. Fix up the dockerfile, make the default buildx compatible with the CI… 

    … and add a comment about how to do cross-platform builds.
    @holdenk
    holdenk committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    bae7ce7 View commit details
    Browse the repository at this point in the history

  7. Update the docs

    @holdenk
    holdenk committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    c87bf14 View commit details
    Browse the repository at this point in the history

  8. Refactor the Makefile to support cross-building images incrementally,… 

    … add ARG OWNER to the Dockerfile's so people can more easily push to their own, add docker buildx & ARM64 support to the CI
    @holdenk
    holdenk committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    55d5f31 View commit details
    Browse the repository at this point in the history

  9. Simplify build-test-all rule

    @holdenk
    holdenk committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    480a329 View commit details
    Browse the repository at this point in the history

  10. Match patch version

    @holdenk
    holdenk committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    65312e2 View commit details
    Browse the repository at this point in the history

  11. Run prettier on docker.yml

    @holdenk
    holdenk committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    22fef86 View commit details
    Browse the repository at this point in the history

  12. Declare and export seperately per docker lint

    @holdenk
    holdenk committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    8a16192 View commit details
    Browse the repository at this point in the history

  13. Skip CI changes

    @holdenk
    holdenk committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    ad949af View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. Revert the makefile changes

    @holdenk
    holdenk committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    8f8b0d1 View commit details
    Browse the repository at this point in the history

  2. Update the Arch comment to match

    @holdenk
    holdenk committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    99a75a2 View commit details
    Browse the repository at this point in the history

  3. back out unrelated changes

    @holdenk
    holdenk committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    cf7dc25 View commit details
    Browse the repository at this point in the history