Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acknowledgement of me :) #2033

Merged
merged 8 commits into from
Nov 29, 2023

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

mathbunnyru commented Nov 15, 2023

@consideRatio @yuvipanda @manics I would like to have an acknowledgement line for me, so let's have a vote on this, if this is ok. Will only merge if get 3 approvals from you.

Copy link
Collaborator

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 🎉 the financial help you have contributed to this project pales in comparison to your care and time contributed to it!!! Thank you @mathbunnyru!!!!!

@mathbunnyru
Copy link
Member Author

❤️ 🎉 the financial help you have contributed to this project pales in comparison to your care and time contributed to it!!! Thank you @mathbunnyru!!!!!

Thank you! Or, because I celebrate my birthday (which was yesterday) in Paris, merci beaucoup! 😃

@mathbunnyru
Copy link
Member Author

@yuvipanda while you're online, may I ask you to take a look here? :)

Copy link
Contributor

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would hit merge if I could :)

@mathbunnyru mathbunnyru merged commit 72601cb into jupyter:main Nov 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants