Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a separate doc page on how to build a custom set of images #2144

Merged
merged 10 commits into from
Sep 10, 2024

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

@minrk @consideRatio please, take a look here.

I think it makes it easier to figure out how to build a custom set of images.

@mathbunnyru
Copy link
Member Author

This is how it looks like: https://jupyter-docker-stacks--2144.org.readthedocs.build/en/2144/using/custom-images.html

Note: I'm not a native speaker, so, please, feel free to correct grammar and so on.

docs/using/custom-images.md Outdated Show resolved Hide resolved
docs/using/custom-images.md Outdated Show resolved Hide resolved
docs/using/custom-images.md Outdated Show resolved Hide resolved
docs/using/custom-images.md Outdated Show resolved Hide resolved
docs/using/custom-images.md Outdated Show resolved Hide resolved
mathbunnyru and others added 2 commits September 9, 2024 14:58
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
@mathbunnyru
Copy link
Member Author

Thanks for such a fast review @manics!

Please, share your opinion, what you think about this PR in general

@mathbunnyru
Copy link
Member Author

mathbunnyru commented Sep 9, 2024

Workflow failure is fine - only link check is failing, and, unfortunately, anaconda.org time outs sometimes.

@mathbunnyru mathbunnyru changed the title Create a separate doc page on how to build custom set of images Create a separate doc page on how to build a custom set of images Sep 9, 2024
Copy link
Contributor

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@minrk minrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mathbunnyru mathbunnyru merged commit 1fb08d7 into jupyter:main Sep 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants