Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename: ROOT_CONTAINER->ROOT_IMAGE, BASE_CONTAINER->BASE_IMAGE #2155

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

mathbunnyru
Copy link
Member

Describe your changes

There is no such thing as parent (base/root) container, it's about images, so let's use proper naming

Issue ticket if applicable

Fix: #2154

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

This is not breaking if you simply run one of our images or use it as a parent image.
But it might be breaking for people who build custom set of images - I think they are advanced users and it's ok to break small things sometimes, they can fix the problem easily.

@manics
Copy link
Contributor

manics commented Oct 9, 2024

What might be nice is to have a (sort of) changelog page, but rather than being comprehensive it only has major/breaking changes along with the date? This could also be a nice place to highlight the planned update to Python 3.12 when it's made.

@mathbunnyru
Copy link
Member Author

What might be nice is to have a (sort of) changelog page, but rather than being comprehensive it only has major/breaking changes along with the date? This could also be a nice place to highlight the planned update to Python 3.12 when it's made.

Done, please, take a look

@mathbunnyru mathbunnyru merged commit 5365b9f into jupyter:main Oct 9, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename ROOT_CONTAINER and BASE_CONTAINER to ROOT_IMAGE and BASE_IMAGE
2 participants