Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jupyter Enterprise gateway #25

Merged
merged 4 commits into from
Sep 16, 2018
Merged

Jupyter Enterprise gateway #25

merged 4 commits into from
Sep 16, 2018

Conversation

lresende
Copy link
Member

@lresende lresende commented Aug 9, 2018

This PR proposes graduating Jupyter Enterprise Gateway project from jupyter-incubator. I would like to open this up for comments.

Adding our mentors/sponsors @rgbkrk and @parente which have been directly involved in the creation of this proposal.

rgbkrk
rgbkrk reviewed Aug 9, 2018
View reviewed changes
jupyter-enterprise-gateway-incorporation/jupyter-enterprise-gateway-incorporation.md Outdated

### Demonstrate continued growth and development.

See "Have an active developer community that offers a sustainable model for future development" and "Have an active user community" sections above.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section is more about -- how is the contributor base expanding beyond that of the initiators of the project? How has that been going? It's a different question than number of users and variance of users.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feedback @rgbkrk, I have pushed a new commit expanding on that section, please let me know if you think we should add any more details.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking great, thanks for coming back to it.

@parente
Copy link
Member

parente commented Aug 11, 2018

@lresende Thanks for prepping this proposal. I added the steering council members as reviewers as a way of notifying them that this proposal exists.

(FYI: I tried to add everyone but TIL that GitHub has a 15 reviewer limit and so it kicked @Ruv7 off when I added the last few folks. Take no offense, @Ruv7, your comments are of course welcome!)

@damianavila
Copy link
Member

(FYI: I tried to add everyone but TIL that GitHub has a 15 reviewer limit and so it kicked @Ruv7 off when I added the last few folks. Take no offense, @Ruv7, your comments are of course welcome!)

@parente, next time you could use https://blog.github.com/2017-06-28-requesting-reviews-from-repository-teams/, it should notify all the members AFAIK.

@lresende
Copy link
Member Author

lresende commented Aug 14, 2018 •
edited
Loading

Thanks for the current feedback so far. If there are any further questions/comments please let us know. Having said that, JupyterCon is a week away and, if possible, we would love to be able to hint/announce the outcome of this proposal at the conference.

blink1073
blink1073 approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal, @lresende!

@blink1073
Copy link
Contributor

Just a thought while I'm here reviewing, it seems some refactoring is in order between kernel_gateway and enterprise_gateway in light of the upcoming standalone jupyter_server: https://github.com/jupyter/jupyter_server.

parente
parente approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member

@parente parente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's unique value in EKG. I agree with @blink1073
that figuring out how to consolidate / refactor with KG and jupyter-server is definitely worth doing as development continues.

One question (that really doesn't change my approval): do you wish to move nb2kg out of incubator at the same time?

@lresende
Copy link
Member Author

@parente if we don't delay EG, it would be very helpful to get nb2kg moved as well.

@lresende
Copy link
Member Author

lresende commented Aug 29, 2018 •
edited
Loading

It was a pleasure to meet several of you guys in person at last week JupyterCon. I know you are all busy, and trying to catch up, but I would appreciate your review of this proposal.

willingc
willingc approved these changes Aug 30, 2018
View reviewed changes
Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all!

Carreau
Carreau approved these changes Aug 30, 2018
View reviewed changes
Copy link
Member

@Carreau Carreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave my +1 during JupyterCon in person but re-add it here. I also gave Luciano ability to create a post on blog.jupyter.org to do an announce if necessary/wanted.

afshin
afshin approved these changes Aug 30, 2018
View reviewed changes
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on 1.0

ellisonbg
ellisonbg approved these changes Aug 30, 2018
View reviewed changes
Copy link
Contributor

@ellisonbg ellisonbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on this work, excited to see move forward. We are already looking at using it ourselves in some deployments.

fperez
fperez approved these changes Sep 3, 2018
View reviewed changes
Copy link
Member

@fperez fperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just catching up with backlog after JupyterCon, sorry I couldn't get to it during the conference!

This is an excellent contribution and I'm very happy to see it graduate, thanks for the excellent work.

@parente
Copy link
Member

parente commented Sep 9, 2018

It looks like we have 8 "yes" and the rest abstaining so far. I don't think the governance docs state a number of votes required to incorporate a new project. Therefore, I'd like to propose a "last call" for votes and comments, and then equate silence with agreement as we have in the past, come Wednesday, September 12th.

@rgbkrk
Copy link
Member

rgbkrk commented Sep 10, 2018

Good plan @parente

@parente
Copy link
Member

parente commented Sep 16, 2018

Caught up in hurricane prep here and missed my self-imposed last-Wednesday deadline.

I see no further comments. I'm going to merge this PR and then move jupyter-incubator/enterprise-gateway and jupyter-incubator/nb2kg into the jupyter org.

Congrats to @lresende and team.

@parente parente merged commit dabcd71 into jupyter:master Sep 16, 2018
@ellisonbg
Copy link
Contributor

ellisonbg commented Sep 18, 2018 via email

@lresende lresende mentioned this pull request Jan 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellisonbg ellisonbg ellisonbg approved these changes

@fperez fperez fperez approved these changes

@parente parente parente approved these changes

@afshin afshin afshin approved these changes

@Carreau Carreau Carreau approved these changes

@rgbkrk rgbkrk rgbkrk approved these changes

@blink1073 blink1073 blink1073 approved these changes

@willingc willingc willingc approved these changes

@jhamrick jhamrick Awaiting requested review from jhamrick

@ivanov ivanov Awaiting requested review from ivanov

@minrk minrk Awaiting requested review from minrk

@jasongrout jasongrout Awaiting requested review from jasongrout

@takluyver takluyver Awaiting requested review from takluyver

@damianavila damianavila Awaiting requested review from damianavila

@SylvainCorlay SylvainCorlay Awaiting requested review from SylvainCorlay

@mpacer mpacer Awaiting requested review from mpacer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@lresende @parente @damianavila @blink1073 @rgbkrk @ellisonbg @fperez @afshin @Carreau @willingc