Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add navigation link to Enterprise Gateway #321

Closed
wants to merge 1 commit into from
Closed

Add navigation link to Enterprise Gateway #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions _data/nav.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ head:
url: https://nbviewer.jupyter.org
newpage: true
- JupyterHub
- title: Enterprise Gateway
# full url added as eg is an external website
url: https://jupyter.org/enterprise_gateway
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be url: /enterprise_gateway like install and community above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make the change, but as the site is not local as in community it will only work when live, where with the current link it works both for dev (local Jekyll serving) and live website. What's the user experience we want for the website developers?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fine w/ just posting a comment to make it obvious to future devs that the jupyter.org needs to be there since the enterprise_gateway page isn't in the jekyll site itself.

Copy link
Member Author

@lresende lresende Jan 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comment and rebased to latest master

- Widgets
- title: Blog
url: https://blog.jupyter.org
Expand Down