-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add voila to website #357
Add voila to website #357
Conversation
-moz-transition: all .05s ease; | ||
-ms-transition: all .05s ease; | ||
-o-transition: all .05s ease; | ||
transition: all .05s ease; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.5s
was really too slow.
@@ -188,7 +211,7 @@ <h3 class="section-header">Currently in use at</h3> | |||
</div> | |||
</section> | |||
<section id="architecture"> | |||
<div class="section-grey"> | |||
<div class="section-white"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternating grey and white. This requires making the logos a bit darker, hence the CSS change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how we decide what goes on the front page, but I made some copy edits in the meantime. Let me know if they work for you, if not I can polish it a bit more.
Thanks for the review. This is great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built this and it looks good.
A future (but very soon) PR that adds the "try" button would be nice, but I think this is ready to go.
Following the JEP on the Voilà incorporation: jupyter/enhancement-proposals#42