Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility fixes to buttons, footer and blue cards #486

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

palewire
Copy link
Collaborator

@palewire palewire commented Dec 6, 2021

Updated accessibility fixes to the site, as raised by Lighthouse, and as prescribed by @isabela-pf in #435.

@palewire
Copy link
Collaborator Author

palewire commented Dec 6, 2021

These changes raise the Lighthouse accessibility score to 100 in my browser testing.

@isabela-pf
Copy link
Contributor

Looks good to me, and good to know it's working with Lighthouse as intended! I'll @ someone with write access if this doesn't get attention in the next week.

Thank you so much for being receptive to feedback, I really appreciate it.

@isabela-pf
Copy link
Contributor

For records, here are some screen shots from the netlify preview as I'm finding it:
Jupyter.org homepage with a text shadow on buttons.
Jupyter.org footer with a darker grey.
Jupyter.org documentation page with darker blue sections.

@Carreau
Copy link
Member

Carreau commented Dec 11, 2021

@isabela-pf I gave you write access, I thought you already had it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants