Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2023 JDC Cohort #766

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Add 2023 JDC Cohort #766

merged 2 commits into from
Aug 19, 2024

Conversation

SylvainCorlay
Copy link
Member

No description provided.

Copy link
Contributor

@JasonWeill JasonWeill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I notice that the "deploy preview" workflow isn't working, because of a problem with dependencies.

@SylvainCorlay
Copy link
Member Author

The latest version of jekyll stops bundling some deps and requires the corresponding gems instead. These gems require Ruby 3. We need to update the build image on netlify so that it has Ruby 3.

@SylvainCorlay
Copy link
Member Author

I temporarily pinned jekyll for the netlify preview to fix the build. Will open a separate issue on this.

Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SylvainCorlay!

@afshin afshin merged commit 7615f05 into jupyter:main Aug 19, 2024
5 checks passed
@SylvainCorlay SylvainCorlay deleted the JDC-2023 branch August 19, 2024 20:29
@SylvainCorlay SylvainCorlay mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants