Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extra_require not respected with .whl (bug in wheel package?) #324

Closed
Carreau opened this issue Dec 30, 2017 · 1 comment · Fixed by #325
Closed

extra_require not respected with .whl (bug in wheel package?) #324

Carreau opened this issue Dec 30, 2017 · 1 comment · Fixed by #325
Milestone
5.2.1

Comments

@Carreau
Copy link
Member

Carreau commented Dec 30, 2017

See discussion in pypa/setuptools#1242
Pr on it's way. We should likely release a 5.2.1
Carreau added a commit to Carreau/jupyter_client that referenced this issue Dec 30, 2017
@Carreau
Parenthesize conditional requirement in setup.py
446ab64 
Du to a likely bug in wheel, the conditional dependency on pytest ends
up being unconditional. Seem like adding parenthesis fix that (as a work
around).

See pypa/setuptools#1242
Closes jupyter#324
@Carreau Carreau mentioned this issue Dec 30, 2017
Closed
@Carreau Carreau added this to the 5.2.1 milestone Dec 30, 2017
@Carreau Carreau mentioned this issue Dec 30, 2017
Merged
Carreau added a commit to Carreau/jupyter_client that referenced this issue Dec 30, 2017
@Carreau
Parenthesize conditional requirement in setup.py
072a087 
Du to a likely bug in wheel, the conditional dependency on pytest ends
up being unconditional. Seem like adding parenthesis fix that (as a work
around).

See pypa/setuptools#1242
Closes jupyter#324
@minrk minrk closed this as completed in #325 Jan 2, 2018
@Carreau
Copy link
Member Author

Carreau commented Jan 2, 2018

Thanks, traveling today I 'll do a release tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.1
Development

Successfully merging a pull request may close this issue.

Parenthesize conditional requirement in setup.py Carreau/jupyter_client
1 participant
@Carreau