don't include link-local addresses (169.254) in public_ips #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
public_ips is meant to return addresses that might be connectable, which link-local are not
ivanov
approved these changes
Sep 21, 2024
There was a problem hiding this comment.
Thanks, Min!
not to code-golf things, too much, but any reason not to add
or addr.startswith("169.254.")to the lines that already have addr.startswith("127.") logic (possibly with an appropriate group, where line 89 would become
if not (ip.startswith("127.") or ip.startswith("169.254.")):`
|
No worries! I added the conditions to avoid link-local addresses being assigned to LOCALHOST. So I could add the There is a lot of duplication here, so maybe I'll try to consolidate the whole thing. |
where dict is like `{"en0": ["1.2.3.4"]}`
minrk
force-pushed
the
link-local-not-public
branch
from
192c997
to
965c25b
Compare
|
consolidated to |
minrk
changed the title
|
thanks, Min, for the patch, the explanation, and the additional cleanup 🎉 |
|
Thanks for the review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
public_ips()is meant to return addresses which might be connectable from other machines, which link-local are not.closes #1039