Migrate SSH tunneling from pyzmq #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this part of code is mainly used in IPython we agreed to move it from pyzmq. It will be easier to maintain here and some planned changes in this code will be easier to apply and release.
minrk
reviewed
Jan 23, 2018
jupyter_client/connect.py
Outdated
| @@ -249,7 +249,7 @@ def tunnel_to_kernel(connection_info, sshserver, sshkey=None): | |||
| (shell, iopub, stdin, hb) : ints | |||
| The four ports on localhost that have been forwarded to the kernel. | |||
| """ | |||
| from zmq.ssh import tunnel | |||
| from jupyter_core.ssh import tunnel | |||
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in ipython/ipython#10934
As this part of code is mainly used in IPython we
agreed to move it from pyzmq. It will be easier to
maintain here and some planned changes in this code
will be easier to apply and release.
Also some code reformatting was applied in
connect.pyfile.